Add histogram features #496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeraZab
reviewed
Jun 26, 2018
| /> | ||
| <HistogramInfoVertical> | ||
| {_( | ||
| 'Note: in vertical orientation X values are used for bins and Y values for weights.' |
There was a problem hiding this comment.
just maybe a , after, in vertical orientation ,
VeraZab
reviewed
Jun 26, 2018
| </HistogramInfoVertical> | ||
| <HistogramInfoHorizontal> | ||
| {_( | ||
| 'Note: in horizontal orientation Y Values are used for bins and X values for weights.' |
|
seems good to me 💃 |
src/components/fields/derived.js
Outdated
| }, | ||
| }); | ||
|
|
||
| export const ColorscaleNumeric = connectToContainer(UnconnectedNumeric, { |
There was a problem hiding this comment.
Oh i see, nevermind ;)
There was a problem hiding this comment.
Actually, "what is this" is a very relevant question :)
I reread the docs and see that it's not needed. zmin and zmax do not depend on zauto - I'm removing this.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #495
Closes #488
Also fixed a small display issue when there's no margin at bottom of panel